-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(API): Report unhandled app crashes to Sentry #4548
Conversation
ada25bf
to
46f5425
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Correct me if I'm wrong, but I believe this only covers crashes based on http request issues, is this correct? So a production execution based on internal triggers (such as timers) would not be reported to Sentry, right?
most other crashes are already being reported since #4394. |
* master: fix(editor): Fix for incorrect execution saving indicator in executions view (#4547) feat(API): Report unhandled app crashes to Sentry (#4548) fix(SendInBlue Trigger Node): fix typo in credential name (#4357) refactor(core): Update rule typescript-eslint/no-unused-vars to not error when variable starts with _ (#4523) refactor: make IPollFunctions emit consistent with trigger emit (#4201) feat: Add cypress e2e tests for signup and signin (#3490) fix(core): Fix manual execution of pinned trigger on main mode (#4535) fix(HTTP Request Node): Show error cause in the output (#4538) refactor(core): Skip interim updates check (no-changelog) (#4536) ci: Revert support for node.js 18 (#4518) (#4537) ci: Start supporting node.js 18 (#4518)
Got released with |
This is a precursor to a proper crash journal that would help with detecting the source of these crashes, and possibly auto-fix them as well. But that will come after the Central Event Bus is ready.