Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(API): Report unhandled app crashes to Sentry #4548

Merged
merged 4 commits into from
Nov 8, 2022

Conversation

netroy
Copy link
Member

@netroy netroy commented Nov 8, 2022

This is a precursor to a proper crash journal that would help with detecting the source of these crashes, and possibly auto-fix them as well. But that will come after the Central Event Bus is ready.

@netroy netroy requested a review from krynble November 8, 2022 14:54
@linear
Copy link

linear bot commented Nov 8, 2022

N8N-4998

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request labels Nov 8, 2022
Copy link
Contributor

@krynble krynble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Correct me if I'm wrong, but I believe this only covers crashes based on http request issues, is this correct? So a production execution based on internal triggers (such as timers) would not be reported to Sentry, right?

@netroy
Copy link
Member Author

netroy commented Nov 8, 2022

LGTM!

Correct me if I'm wrong, but I believe this only covers crashes based on http request issues, is this correct? So a production execution based on internal triggers (such as timers) would not be reported to Sentry, right?

most other crashes are already being reported since #4394.
This change only adds error reporting for errors that happen during DB initialization, and an error on post-crash restarts.

@netroy netroy merged commit 2425c10 into master Nov 8, 2022
@netroy netroy deleted the N8N-4998-crash-reporting branch November 8, 2022 16:06
MiloradFilipovic added a commit that referenced this pull request Nov 8, 2022
* master:
  fix(editor): Fix for incorrect execution saving indicator in executions view (#4547)
  feat(API): Report unhandled app crashes to Sentry (#4548)
  fix(SendInBlue Trigger Node): fix typo in credential name (#4357)
  refactor(core): Update rule typescript-eslint/no-unused-vars to not error when variable starts with _ (#4523)
  refactor: make IPollFunctions emit consistent with trigger emit (#4201)
  feat: Add cypress e2e tests for signup and signin (#3490)
  fix(core): Fix manual execution of pinned trigger on main mode (#4535)
  fix(HTTP Request Node): Show error cause in the output (#4538)
  refactor(core): Skip interim updates check (no-changelog) (#4536)
  ci: Revert support for node.js 18 (#4518) (#4537)
  ci: Start supporting node.js 18 (#4518)
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 8, 2022
@janober
Copy link
Member

janober commented Nov 10, 2022

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants